Skip to content

CI: remove light-aws-builder specs, use binary from image.#658

Merged
aramprice merged 2 commits into
ubuntu-jammyfrom
remove-aws-light-stemcell-tests
Jun 22, 2026
Merged

CI: remove light-aws-builder specs, use binary from image.#658
aramprice merged 2 commits into
ubuntu-jammyfrom
remove-aws-light-stemcell-tests

Conversation

@aramprice

@aramprice aramprice commented Jun 20, 2026

Copy link
Copy Markdown
Member

These specs moved to that pipeline, and the docker image now contains the light-aws-builder binary.

NOTE: the publisher pipeline must be reconfigured after merging.

Copilot AI review requested due to automatic review settings June 20, 2026 00:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@aramprice aramprice requested a review from Alphasite June 20, 2026 00:04
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@aramprice, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 6 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e01742b2-6609-44f5-8b09-19f7234edfc2

📥 Commits

Reviewing files that changed from the base of the PR and between d69bceb and 5ad591a.

📒 Files selected for processing (17)
  • ci/pipelines/publisher.yml
  • ci/tasks/light-aws/build.sh
  • ci/tasks/light-aws/build.yml
  • ci/tasks/light-aws/cleanup-ami.sh
  • ci/tasks/light-aws/cleanup-ami.yml
  • ci/tasks/light-aws/run-upload-test.sh
  • ci/tasks/light-aws/run-upload-test.yml
  • ci/tasks/light-aws/test-drivers.sh
  • ci/tasks/light-aws/test-drivers.yml
  • ci/tasks/light-aws/test-integration.sh
  • ci/tasks/light-aws/test-integration.yml
  • ci/tasks/light-aws/test-unit.sh
  • ci/tasks/light-aws/test-unit.yml
  • ci/tasks/light-aws/us-gov-merge-builds.yml
  • ci/tasks/light-google/create-public-image.sh
  • ci/tasks/light-google/deploy-skeletal.sh
  • ci/tasks/light-google/make-raw-from-heavy-stemcell.sh

Walkthrough

The pull request removes four AWS CI jobs (test-aws-unit, test-aws-drivers, test-aws-integration, cleanup-light-aws-builder-test-amis) from the Concourse pipeline and refactors the build_light_aws_stemcell_new YTT helper to accept prefix-based parameters instead of explicit builder_src and region parameters. The light-aws-builder-src git resource is removed and the registry-image resource is renamed from light-stemcell-builder-registry-image to aws-light-stemcell-builder-registry-image. The Google make-raw-from-heavy-stemcell task is updated to use gce-cpi-release-registry-image. In build.sh, the stemcell builder invocation is replaced from go run main.go to a direct light-stemcell-builder binary call. Builder-src inputs are removed from build.yml, cleanup-ami.yml, run-upload-test.yml, and us-gov-merge-builds.yml task definitions. Bash parameter validation is hardened throughout by replacing unquoted : ${VAR:?} checks with quoted : "${VAR:?}" syntax and quoting all variable and path uses in heredocs, file operations, and command substitutions. The cleanup-ami.sh script introduces stricter environment validation and refactors AMI selection with a reusable past_due_query expression. The make-raw-from-heavy-stemcell.sh script adds BUCKET_NAME and STEMCELL_BUCKET_PATH validation, refactors stemcell_url to accept a name parameter, and simplifies the existence check to a direct conditional. The create-public-image.sh script restructures gcloud command arguments for readability and changes intermediate image file creation to use touch.

Suggested reviewers

  • mkocher
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description is incomplete; it lacks clear explanation of why changes were made and does not follow the template's merge-forward strategy guidance for branch targeting. Clarify which stemcell branch this targets and provide details about the migration to the separate pipeline and Docker image changes.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing light-aws-builder specs and using the binary from the Docker image instead.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-aws-light-stemcell-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aramprice aramprice requested review from a team and lnguyen and removed request for a team June 20, 2026 00:07

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci/pipelines/publisher.yml`:
- Line 19: The image reference `light-stemcell-builder-registry-image` on line
19 does not match the actual resource name that has been renamed to
`aws-light-stemcell-builder-registry-image` (as defined at line 751 and fetched
by the job at line 130). Update the image field on line 19 from
`light-stemcell-builder-registry-image` to
`aws-light-stemcell-builder-registry-image` to resolve the artifact name
mismatch so the build-<prefix>-stemcell task can locate the correct image at
runtime.

In `@ci/tasks/light-google/create-public-image.sh`:
- Around line 65-67: The `touch image` command on line 65 only updates the
modification time without clearing existing file contents, which means if the
image file already exists from a previous extraction, it will retain the full
heavy payload when calculating the SHA1 hash and packaging into the tar archive.
Replace `touch image` with a command that actually empties the file contents,
such as using output redirection (> image) or truncate, to ensure image is
created as an empty light placeholder before the SHA1 calculation on line 66.
- Around line 53-54: The guest_os_features_flag variable is being passed as a
quoted argument to gcloud compute images create even when it is empty, which
causes gcloud argument parsing to fail for configurations with no features
enabled. Remove the quotes around the guest_os_features_flag variable and
conditionally include the flag only when it contains a non-empty value, such as
by using parameter expansion (e.g., only adding the flag and its value when the
variable is not empty).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: aaf392a4-d67f-4fbf-8849-6245785807f6

📥 Commits

Reviewing files that changed from the base of the PR and between 0488435 and 5ee4a96.

📒 Files selected for processing (13)
  • ci/pipelines/publisher.yml
  • ci/tasks/light-aws/build.sh
  • ci/tasks/light-aws/cleanup-ami.sh
  • ci/tasks/light-aws/cleanup-ami.yml
  • ci/tasks/light-aws/test-drivers.sh
  • ci/tasks/light-aws/test-drivers.yml
  • ci/tasks/light-aws/test-integration.sh
  • ci/tasks/light-aws/test-integration.yml
  • ci/tasks/light-aws/test-unit.sh
  • ci/tasks/light-aws/test-unit.yml
  • ci/tasks/light-google/create-public-image.sh
  • ci/tasks/light-google/deploy-skeletal.sh
  • ci/tasks/light-google/make-raw-from-heavy-stemcell.sh
💤 Files with no reviewable changes (8)
  • ci/tasks/light-aws/test-integration.yml
  • ci/tasks/light-aws/cleanup-ami.yml
  • ci/tasks/light-aws/cleanup-ami.sh
  • ci/tasks/light-aws/test-drivers.yml
  • ci/tasks/light-aws/test-unit.sh
  • ci/tasks/light-aws/test-unit.yml
  • ci/tasks/light-aws/test-drivers.sh
  • ci/tasks/light-aws/test-integration.sh

Comment thread ci/pipelines/publisher.yml Outdated
Comment thread ci/tasks/light-google/create-public-image.sh Outdated
Comment thread ci/tasks/light-google/create-public-image.sh Outdated
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 20, 2026
@github-project-automation github-project-automation Bot moved this from Waiting for Changes | Open for Contribution to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jun 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.

Comment thread ci/tasks/light-google/create-public-image.sh
Comment thread ci/tasks/light-google/create-public-image.sh
Comment thread ci/tasks/light-aws/build.sh
Comment thread ci/pipelines/publisher.yml
Comment thread ci/pipelines/publisher.yml
Comment thread ci/pipelines/publisher.yml

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci/tasks/light-aws/cleanup-ami.sh`:
- Around line 14-16: The parameter expansion guards for AWS credentials in the
export statements for AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, and
AWS_DEFAULT_REGION are using the `?` operator which only checks if variables are
set, but allows empty values. Change each guard from the current
`${variable?'must be set'}` format to `${variable:?'must be set'}` format by
adding a colon before the question mark. This will ensure that the script fails
immediately if any of these credential variables are empty or unset, rather than
passing validation and failing later during AWS API calls.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8e0214ee-af7c-4d1a-bc21-f711bf6d1f9d

📥 Commits

Reviewing files that changed from the base of the PR and between 5ee4a96 and 3fcb013.

📒 Files selected for processing (17)
  • ci/pipelines/publisher.yml
  • ci/tasks/light-aws/build.sh
  • ci/tasks/light-aws/build.yml
  • ci/tasks/light-aws/cleanup-ami.sh
  • ci/tasks/light-aws/cleanup-ami.yml
  • ci/tasks/light-aws/run-upload-test.sh
  • ci/tasks/light-aws/run-upload-test.yml
  • ci/tasks/light-aws/test-drivers.sh
  • ci/tasks/light-aws/test-drivers.yml
  • ci/tasks/light-aws/test-integration.sh
  • ci/tasks/light-aws/test-integration.yml
  • ci/tasks/light-aws/test-unit.sh
  • ci/tasks/light-aws/test-unit.yml
  • ci/tasks/light-aws/us-gov-merge-builds.yml
  • ci/tasks/light-google/create-public-image.sh
  • ci/tasks/light-google/deploy-skeletal.sh
  • ci/tasks/light-google/make-raw-from-heavy-stemcell.sh
💤 Files with no reviewable changes (8)
  • ci/tasks/light-aws/test-drivers.yml
  • ci/tasks/light-aws/test-unit.yml
  • ci/tasks/light-aws/test-unit.sh
  • ci/tasks/light-aws/build.yml
  • ci/tasks/light-aws/test-integration.sh
  • ci/tasks/light-aws/us-gov-merge-builds.yml
  • ci/tasks/light-aws/test-integration.yml
  • ci/tasks/light-aws/test-drivers.sh

Comment thread ci/tasks/light-aws/cleanup-ami.sh Outdated
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Waiting for Changes | Open for Contribution in Foundational Infrastructure Working Group Jun 20, 2026
@aramprice aramprice force-pushed the remove-aws-light-stemcell-tests branch from 3fcb013 to d69bceb Compare June 22, 2026 18:42

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci/pipelines/publisher.yml`:
- Around line 125-128: The in_parallel block contains an empty do: branch on
line 126 that has no nested steps, while the two build_light_aws_stemcell_new
calls on the following lines are sibling list items under in_parallel rather
than children of the do branch. Remove the empty do: line entirely so that the
two build_light_aws_stemcell_new function calls remain as direct children of
in_parallel with proper indentation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3c48bf63-3e05-4d4b-a59b-e0c0abcd80f6

📥 Commits

Reviewing files that changed from the base of the PR and between 3fcb013 and d69bceb.

📒 Files selected for processing (17)
  • ci/pipelines/publisher.yml
  • ci/tasks/light-aws/build.sh
  • ci/tasks/light-aws/build.yml
  • ci/tasks/light-aws/cleanup-ami.sh
  • ci/tasks/light-aws/cleanup-ami.yml
  • ci/tasks/light-aws/run-upload-test.sh
  • ci/tasks/light-aws/run-upload-test.yml
  • ci/tasks/light-aws/test-drivers.sh
  • ci/tasks/light-aws/test-drivers.yml
  • ci/tasks/light-aws/test-integration.sh
  • ci/tasks/light-aws/test-integration.yml
  • ci/tasks/light-aws/test-unit.sh
  • ci/tasks/light-aws/test-unit.yml
  • ci/tasks/light-aws/us-gov-merge-builds.yml
  • ci/tasks/light-google/create-public-image.sh
  • ci/tasks/light-google/deploy-skeletal.sh
  • ci/tasks/light-google/make-raw-from-heavy-stemcell.sh
💤 Files with no reviewable changes (8)
  • ci/tasks/light-aws/test-unit.sh
  • ci/tasks/light-aws/test-unit.yml
  • ci/tasks/light-aws/test-drivers.sh
  • ci/tasks/light-aws/test-integration.sh
  • ci/tasks/light-aws/build.yml
  • ci/tasks/light-aws/test-integration.yml
  • ci/tasks/light-aws/us-gov-merge-builds.yml
  • ci/tasks/light-aws/test-drivers.yml

Comment thread ci/pipelines/publisher.yml
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 22, 2026
@github-project-automation github-project-automation Bot moved this from Waiting for Changes | Open for Contribution to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jun 22, 2026
KauzClay
KauzClay previously approved these changes Jun 22, 2026
@aramprice aramprice requested a review from Copilot June 22, 2026 18:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@aramprice aramprice dismissed stale reviews from KauzClay and coderabbitai[bot] via ca1b9fa June 22, 2026 19:19
These specs moved to that pipeline, and the docker image now
contains the `light-aws-builder` binary. Also contains:

- shellcheck cleanup
- removes aws-light-stemcell-builder src
- use prefix, not prefix, and region
- out of band: update credhub entry

@Alphasite Alphasite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly CI changes but seems ok.

@aramprice aramprice force-pushed the remove-aws-light-stemcell-tests branch from ca1b9fa to 5ad591a Compare June 22, 2026 19:27
@aramprice aramprice merged commit 718a56e into ubuntu-jammy Jun 22, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jun 22, 2026
@aramprice aramprice deleted the remove-aws-light-stemcell-tests branch June 22, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants