CI: remove light-aws-builder specs, use binary from image.#658
Conversation
|
Warning Review limit reached
More reviews will be available in 15 minutes and 6 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (17)
WalkthroughThe pull request removes four AWS CI jobs (test-aws-unit, test-aws-drivers, test-aws-integration, cleanup-light-aws-builder-test-amis) from the Concourse pipeline and refactors the build_light_aws_stemcell_new YTT helper to accept prefix-based parameters instead of explicit builder_src and region parameters. The light-aws-builder-src git resource is removed and the registry-image resource is renamed from light-stemcell-builder-registry-image to aws-light-stemcell-builder-registry-image. The Google make-raw-from-heavy-stemcell task is updated to use gce-cpi-release-registry-image. In build.sh, the stemcell builder invocation is replaced from Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci/pipelines/publisher.yml`:
- Line 19: The image reference `light-stemcell-builder-registry-image` on line
19 does not match the actual resource name that has been renamed to
`aws-light-stemcell-builder-registry-image` (as defined at line 751 and fetched
by the job at line 130). Update the image field on line 19 from
`light-stemcell-builder-registry-image` to
`aws-light-stemcell-builder-registry-image` to resolve the artifact name
mismatch so the build-<prefix>-stemcell task can locate the correct image at
runtime.
In `@ci/tasks/light-google/create-public-image.sh`:
- Around line 65-67: The `touch image` command on line 65 only updates the
modification time without clearing existing file contents, which means if the
image file already exists from a previous extraction, it will retain the full
heavy payload when calculating the SHA1 hash and packaging into the tar archive.
Replace `touch image` with a command that actually empties the file contents,
such as using output redirection (> image) or truncate, to ensure image is
created as an empty light placeholder before the SHA1 calculation on line 66.
- Around line 53-54: The guest_os_features_flag variable is being passed as a
quoted argument to gcloud compute images create even when it is empty, which
causes gcloud argument parsing to fail for configurations with no features
enabled. Remove the quotes around the guest_os_features_flag variable and
conditionally include the flag only when it contains a non-empty value, such as
by using parameter expansion (e.g., only adding the flag and its value when the
variable is not empty).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: aaf392a4-d67f-4fbf-8849-6245785807f6
📒 Files selected for processing (13)
ci/pipelines/publisher.ymlci/tasks/light-aws/build.shci/tasks/light-aws/cleanup-ami.shci/tasks/light-aws/cleanup-ami.ymlci/tasks/light-aws/test-drivers.shci/tasks/light-aws/test-drivers.ymlci/tasks/light-aws/test-integration.shci/tasks/light-aws/test-integration.ymlci/tasks/light-aws/test-unit.shci/tasks/light-aws/test-unit.ymlci/tasks/light-google/create-public-image.shci/tasks/light-google/deploy-skeletal.shci/tasks/light-google/make-raw-from-heavy-stemcell.sh
💤 Files with no reviewable changes (8)
- ci/tasks/light-aws/test-integration.yml
- ci/tasks/light-aws/cleanup-ami.yml
- ci/tasks/light-aws/cleanup-ami.sh
- ci/tasks/light-aws/test-drivers.yml
- ci/tasks/light-aws/test-unit.sh
- ci/tasks/light-aws/test-unit.yml
- ci/tasks/light-aws/test-drivers.sh
- ci/tasks/light-aws/test-integration.sh
5ee4a96 to
0f82ba6
Compare
0f82ba6 to
f80d485
Compare
f80d485 to
3fcb013
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci/tasks/light-aws/cleanup-ami.sh`:
- Around line 14-16: The parameter expansion guards for AWS credentials in the
export statements for AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, and
AWS_DEFAULT_REGION are using the `?` operator which only checks if variables are
set, but allows empty values. Change each guard from the current
`${variable?'must be set'}` format to `${variable:?'must be set'}` format by
adding a colon before the question mark. This will ensure that the script fails
immediately if any of these credential variables are empty or unset, rather than
passing validation and failing later during AWS API calls.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8e0214ee-af7c-4d1a-bc21-f711bf6d1f9d
📒 Files selected for processing (17)
ci/pipelines/publisher.ymlci/tasks/light-aws/build.shci/tasks/light-aws/build.ymlci/tasks/light-aws/cleanup-ami.shci/tasks/light-aws/cleanup-ami.ymlci/tasks/light-aws/run-upload-test.shci/tasks/light-aws/run-upload-test.ymlci/tasks/light-aws/test-drivers.shci/tasks/light-aws/test-drivers.ymlci/tasks/light-aws/test-integration.shci/tasks/light-aws/test-integration.ymlci/tasks/light-aws/test-unit.shci/tasks/light-aws/test-unit.ymlci/tasks/light-aws/us-gov-merge-builds.ymlci/tasks/light-google/create-public-image.shci/tasks/light-google/deploy-skeletal.shci/tasks/light-google/make-raw-from-heavy-stemcell.sh
💤 Files with no reviewable changes (8)
- ci/tasks/light-aws/test-drivers.yml
- ci/tasks/light-aws/test-unit.yml
- ci/tasks/light-aws/test-unit.sh
- ci/tasks/light-aws/build.yml
- ci/tasks/light-aws/test-integration.sh
- ci/tasks/light-aws/us-gov-merge-builds.yml
- ci/tasks/light-aws/test-integration.yml
- ci/tasks/light-aws/test-drivers.sh
3fcb013 to
d69bceb
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci/pipelines/publisher.yml`:
- Around line 125-128: The in_parallel block contains an empty do: branch on
line 126 that has no nested steps, while the two build_light_aws_stemcell_new
calls on the following lines are sibling list items under in_parallel rather
than children of the do branch. Remove the empty do: line entirely so that the
two build_light_aws_stemcell_new function calls remain as direct children of
in_parallel with proper indentation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3c48bf63-3e05-4d4b-a59b-e0c0abcd80f6
📒 Files selected for processing (17)
ci/pipelines/publisher.ymlci/tasks/light-aws/build.shci/tasks/light-aws/build.ymlci/tasks/light-aws/cleanup-ami.shci/tasks/light-aws/cleanup-ami.ymlci/tasks/light-aws/run-upload-test.shci/tasks/light-aws/run-upload-test.ymlci/tasks/light-aws/test-drivers.shci/tasks/light-aws/test-drivers.ymlci/tasks/light-aws/test-integration.shci/tasks/light-aws/test-integration.ymlci/tasks/light-aws/test-unit.shci/tasks/light-aws/test-unit.ymlci/tasks/light-aws/us-gov-merge-builds.ymlci/tasks/light-google/create-public-image.shci/tasks/light-google/deploy-skeletal.shci/tasks/light-google/make-raw-from-heavy-stemcell.sh
💤 Files with no reviewable changes (8)
- ci/tasks/light-aws/test-unit.sh
- ci/tasks/light-aws/test-unit.yml
- ci/tasks/light-aws/test-drivers.sh
- ci/tasks/light-aws/test-integration.sh
- ci/tasks/light-aws/build.yml
- ci/tasks/light-aws/test-integration.yml
- ci/tasks/light-aws/us-gov-merge-builds.yml
- ci/tasks/light-aws/test-drivers.yml
ca1b9fa
These specs moved to that pipeline, and the docker image now contains the `light-aws-builder` binary. Also contains: - shellcheck cleanup - removes aws-light-stemcell-builder src
- use prefix, not prefix, and region - out of band: update credhub entry
Alphasite
left a comment
There was a problem hiding this comment.
Mostly CI changes but seems ok.
ca1b9fa to
5ad591a
Compare
These specs moved to that pipeline, and the docker image now contains the
light-aws-builderbinary.NOTE: the
publisherpipeline must be reconfigured after merging.